[AnnotationsToAttributes] Add @requires translation to attributes (#441)#442
Merged
samsonasik merged 1 commit intorectorphp:mainfrom Jan 28, 2025
Merged
Conversation
andrewnicols
force-pushed
the
RequiresAnnotationToAttribute
branch
from
9453554 to
a15d46d
Compare
samsonasik
reviewed
Jan 17, 2025
rules/AnnotationsToAttributes/Rector/Class_/RequiresAnnotationWithValueToAttributeRector.php
Show resolved
Hide resolved
samsonasik
reviewed
Jan 17, 2025
rules/AnnotationsToAttributes/Rector/Class_/RequiresAnnotationWithValueToAttributeRector.php
Show resolved
Hide resolved
samsonasik
reviewed
Jan 17, 2025
rules/AnnotationsToAttributes/Rector/Class_/RequiresAnnotationWithValueToAttributeRector.php
Show resolved
Hide resolved
samsonasik
reviewed
Jan 17, 2025
rules/AnnotationsToAttributes/Rector/Class_/RequiresAnnotationWithValueToAttributeRector.php
Outdated
Show resolved
Hide resolved
andrewnicols
force-pushed
the
RequiresAnnotationToAttribute
branch
from
a15d46d to
8986bbe
Compare
Contributor
Author
|
Thanks @samsonasik, I've made the change to add |
Member
|
You can run: to fix CI |
andrewnicols
force-pushed
the
RequiresAnnotationToAttribute
branch
from
8986bbe to
a70b5e6
Compare
Member
|
I think this can be registered to config set https://github.com/rectorphp/rector-phpunit/blob/main/config/sets/annotations-to-attributes.php |
Contributor
Author
Agreed - I've added it to the set, and I've copied the test into the set Fixtures folder too. |
andrewnicols
force-pushed
the
RequiresAnnotationToAttribute
branch
from
a70b5e6 to
a6d7151
Compare
Contributor
Author
|
Hi @samsonasik, Is there anything else I need to do for this PR? Thanks |
samsonasik
approved these changes
Jan 28, 2025
Member
|
Looks good, thank you @andrewnicols |
Member
|
Thank you 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.