Bump to PHPStan 2.1.34 and fix compatible code#7844
Merged
TomasVotruba merged 13 commits intomainfrom Jan 19, 2026
Merged
Conversation
Member
Author
|
@TomasVotruba it seems there is error on ContainerMemento after update to PHPStan 2.1.34 PHP Warning: Undefined array key 0 in /home/runner/work/rector-src/rector-src/src/DependencyInjection/PHPStan/PHPStanContainerMemento.php on line 44 see https://github.com/rectorphp/rector-src/actions/runs/21150186226/job/60824424332?pr=7844#step:8:10 |
3d693a2 to
3449037
Compare
7d8b43f to
30c7501
Compare
7fe9647 to
ecc834b
Compare
Member
Author
|
@TomasVotruba ready for merge 👍 the notice on |
This was referenced Jan 19, 2026
Member
|
LGTM 👌 |
Member
Author
|
Released immediate rector 2.3.2 for it :) https://github.com/rectorphp/rector/releases/tag/2.3.2 |
calebdw
added a commit
to calebdw/rector-src
that referenced
this pull request
Jan 20, 2026
This reverts commit 01406fb.
calebdw
added a commit
to calebdw/rector-src
that referenced
this pull request
Jan 20, 2026
This reverts commit 01406fb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the change:
VariadicFunctionsVisitorandVariadicMethodsVisitorPHPStan\Analyser\Fiber\FiberScope, need to be converted to:on
PHPStanNodeScopeResolverand on use of$scope->getParentScope()OptimizedSingleFileSourceLocatorneed to be created viaOptimizedSingleFileSourceLocatorRepositoryFixes rectorphp/rector#9604