Move core schema generation logic for path types inside the `Generate… #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Schema` class (pydantic#10846) Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
| if path_type is bytes: | ||
| if isinstance(input_value, bytes): | ||
| try: | ||
| input_value = input_value.decode() |
There was a problem hiding this comment.
Missing error handling for the case where bytes decoding fails but the input is not bytes. The outer if/else checks for bytes type but still wraps a decoding attempt in a try/except, which won't get reached for non-bytes input.
💬 Reply with
/praiseto tell me that this comment was useful.
Is this comment irrelevant to your project? Reply with
/ignoreto no longer receive comments like this in the future.
Owner
Author
There was a problem hiding this comment.
:( saj, you were wrong
|
😱 Found 1 issue. Time to roll up your sleeves! 😱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Schema` class (pydantic#10846)
Change Summary
Related issue number
Checklist