Fix crash in DebounceAsyncSequence #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expression `UInt64(self.dueTime - Date().timeIntervalSince(lastEmission))` crashes if `self.dueTime - Date().timeIntervalSince(lastEmission)` is less than `UInt64.min`. Since `Date().timeIntervalSince(lastEmission)` seems like it normally evaluates to something near 0, the suspicion is that the crash must occur when the process is suspended in between `lastEmission = Date()` and `Date().timeIntervalSince(lastEmission)`. This commit removes `lastEmission` entirely and ensures that the value passed to `UInt64.min` is non-negative. Fixes reddavis#60
macdrevx
commented
Aug 6, 2025
| try? await Task.sleep(nanoseconds: delay) | ||
|
|
||
| let sleep = Task<RaceResult, Never> { [dueTime] in | ||
| try? await Task.sleep(nanoseconds: UInt64(Swift.max(dueTime, 0)) * NSEC_PER_SEC) |
Author
There was a problem hiding this comment.
An unrelated problem here is that dueTime is converted to an integer before multiplication with NSEC_PER_SEC which means that any fractional seconds are lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expression
UInt64(self.dueTime - Date().timeIntervalSince(lastEmission))crashes ifself.dueTime - Date().timeIntervalSince(lastEmission)is less thanUInt64.min.Since
Date().timeIntervalSince(lastEmission)seems like it normally evaluates to something near 0, the suspicion is that the crash must occur when the process is suspended in betweenlastEmission = Date()andDate().timeIntervalSince(lastEmission).This commit removes
lastEmissionentirely and ensures that the value passed toUInt64.minis non-negative.Fixes #60