Upgrade zen-fs deps #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunsch
approved these changes
Jan 6, 2025
niedzielski
reviewed
Jan 6, 2025
Contributor
niedzielski
left a comment
niedzielski
left a comment
There was a problem hiding this comment.
unit test failures look similar to #40.
package.json
Outdated
| }, | ||
| "dist/play-pen.js": { | ||
| "none": "26580 KB", | ||
| "none": "26817 KB", |
Contributor
There was a problem hiding this comment.
I'm surprised the uncompressed size increased so much and the compressed didn't need to change at all.
Contributor
There was a problem hiding this comment.
The size test doesn't fail locally, so I based the size on the number reported by the CI runner 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
💸 TL;DR
Migrates the unsupported dependency, follow up for #40
📜 Details
Design Doc
Jira
🧪 Testing Steps / Validation
✅ Checks