Open
Conversation
Contributor
|
@itewk ; you OK to review? |
Contributor
|
@garethahealy i'm trying to figure out why your new test didn't run as a github action? any idea? |
itewk
requested changes
Nov 14, 2025
Contributor
There was a problem hiding this comment.
@garethahealy can you move this to a ci folder rather then _test. then the automatic github action testing will pick this up.
Contributor
There was a problem hiding this comment.
you want @marpears - as he was the PR raiser :)
Contributor
There was a problem hiding this comment.
whoooops. sorry. missread that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR About?
OLM v1 is a declarative and GitOps friendly way of installing operators or extensions, and has been GA since OpenShift 4.18.
In this PR, a new helm chart named olmv1 has been created which configures ClusterExtension CRs and the supporting manifests needed to provide the necessary rbac for installation to complete.
Having a chart for OLM v1 will hopefully help boost the testing and adoption effort needed to ensure compatibility of all operators.
How do we test this?
The chart can be linted using this command:
helm lint -f charts/olmv1/_test/values.yaml charts/olmv1The conftest script used by the GitHub action has been updated to include this new chart and uses the test values file.
cc: @redhat-cop/day-in-the-life