Skip to content

Conversation

@rm3l
Copy link
Member

@rm3l rm3l commented Jan 16, 2026

Description of the change

Add @OpinionatedHeron to the list of reviewers and to the allowlist that treats PRs as internal (bypassing the manual approval gate for external forks).

Which issue(s) does this PR fix or relate to

How to test changes / Special notes to the reviewer

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes. The pre-commit Workflow will do this automatically for you if needed.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

@sonarqubecloud
Copy link

@rhdh-qodo-merge
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🔒 Security concerns

Privilege change:
Adding OpinionatedHeron to the workflow allowlist can reduce manual-approval requirements for PRs from that user on external forks (i.e., they may be treated as internal). Validate that this is an intended trust/permission change and that the account is controlled/secured appropriately.

⚡ Recommended focus areas for review

Access Control

Adding OpinionatedHeron to the internal allowlist changes which PRs bypass the manual approval gate for external forks. Confirm this account is intended to be trusted at the same level as other allowlisted users and that this aligns with the repository’s reviewer/maintainer policy.

environment:
  ${{ (github.event.pull_request.head.repo.full_name == github.repository ||
  contains(fromJSON('["gazarenkov","kadel","nickboldt","rm3l","kim-tsao","Fortune-Ndlovu","subhashkhileri","zdrapela","openshift-cherrypick-robot", "OpinionatedHeron"]'), github.event.pull_request.user.login)) && 'internal' || 'external' }}
runs-on: ubuntu-latest
Maintainability

The allowlist is embedded as a JSON string in the workflow expression, which can drift from OWNERS over time. Consider ensuring there is a single source of truth (or a lightweight process/check) so that reviewer additions/removals don’t require updates in multiple places.

${{ (github.event.pull_request.head.repo.full_name == github.repository ||
contains(fromJSON('["gazarenkov","kadel","nickboldt","rm3l","kim-tsao","Fortune-Ndlovu","subhashkhileri","zdrapela","openshift-cherrypick-robot", "OpinionatedHeron"]'), github.event.pull_request.user.login)) && 'internal' || 'external' }}
📄 References
  1. redhat-developer/rhdh-chart/charts/orchestrator-software-templates-infra/ci/upstream-values.yaml [1-27]
  2. redhat-developer/rhdh-chart/charts/orchestrator-infra/ci/upstream-olm-values.yaml [1-13]
  3. redhat-developer/rhdh-chart/charts/backstage/ci/with-orchestrator-values.yaml [1-21]
  4. redhat-developer/rhdh-chart/charts/orchestrator-software-templates/ci/upstream-values.yaml [1-16]
  5. redhat-developer/rhdh-chart/charts/orchestrator-software-templates-infra/Chart.yaml [1-17]
  6. redhat-developer/rhdh-chart/charts/orchestrator-software-templates/Chart.yaml [1-18]
  7. redhat-developer/rhdh-chart/charts/orchestrator-infra/Chart.yaml [1-18]
  8. redhat-developer/rhdh-chart/charts/orchestrator-software-templates-infra/values.yaml [1-18]

@rhdh-qodo-merge
Copy link

PR Type

Other


Description

  • Add OpinionatedHeron to the internal reviewers list in OWNERS file

  • Include OpinionatedHeron in pre-commit workflow authorization check

  • Allows OpinionatedHeron to bypass external fork approval requirement


File Walkthrough

Relevant files
Configuration changes
OWNERS
Add OpinionatedHeron to reviewers list                                     

OWNERS

  • Added OpinionatedHeron to the reviewers list
+1/-0     
pre-commit.yaml
Add OpinionatedHeron to workflow authorization                     

.github/workflows/pre-commit.yaml

  • Added OpinionatedHeron to the internal authorization check list
  • Allows OpinionatedHeron to skip external fork approval requirement
+1/-1     

@rhdh-qodo-merge
Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Correct list indentation

In the OWNERS file, fix the indentation for the new reviewer OpinionatedHeron to
align with the other list items by adding a space.

OWNERS [16]

+- OpinionatedHeron
 
-
  • Apply / Chat
Suggestion importance[1-10]: 5

__

Why: The suggestion correctly identifies an indentation issue in the OWNERS file, which could affect how the file is parsed. However, the provided existing_code and improved_code snippets are incorrect, which lowers the score.

Low
  • More

@rm3l rm3l changed the title chore: add OpinionatedHeron to the list of reviewers and auto-run workflows chore: add OpinionatedHeron to the list of reviewers and auto-run workflows Jan 16, 2026
@rm3l
Copy link
Member Author

rm3l commented Jan 16, 2026

/verify-owners

@rm3l rm3l merged commit b2807f0 into redhat-developer:main Jan 16, 2026
6 of 7 checks passed
@rm3l rm3l deleted the chore/add_OpinionatedHeron_to_reviewers branch January 16, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant