fix: remove webpack dependency version inconsistency #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
force-pushed
the
fix-webpack-dependency
branch
from
e518603 to
cd03216
Compare
|
nickboldt
approved these changes
Jan 6, 2026
Member
nickboldt
left a comment
nickboldt
left a comment
There was a problem hiding this comment.
seems reasonable.
/lgtm
/make-it-so
/approve
/get-me-that-horizon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix webpack version mismatch causing plugin export failure
Problem
plugin exportfails when run vianpxwith:Root Cause
The CLI declares
webpack@~5.95.0, but its dependency@backstage/cli@0.34.1requireswebpack@~5.96.0.When installed via
npx, npm/yarn installs both versions:webpack@5.96.xhoisted at root (from@backstage/cli)webpack@5.95.xnested in CLI's node_modulesThe
@openshift/dynamic-plugin-sdk-webpackplugin (which has webpack as a peer dependency) resolves to the hoisted 5.96.x, while the CLI's bundler uses the nested 5.95.x. This causes webpack'sinstanceof Compilationcheck to fail because theCompilationobjects come from different webpack instances.Fix
Align webpack version to
~5.96.0to match@backstage/cli@0.34.1.