-
Notifications
You must be signed in to change notification settings - Fork 34
fix(nightly): switch to plugins OCI references in example to fix the nightly checks #2224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nightly): switch to plugins OCI references in example to fix the nightly checks #2224
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cherry-pick release-1.9 |
|
@rm3l: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR TypeBug fix Description
|
| Relevant files | |||
|---|---|---|---|
| Bug fix |
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||||
| # supports ISO duration, "human duration (used below) | ||
| timeout: { minutes: 3} | ||
| initialDelay: { seconds: 15} | ||
| - package: ./dynamic-plugins/dist/backstage-plugin-techdocs-backend-dynamic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped this as it is not strictly necessary in the tests. It seems to be enabled out of the box anyway by RHDH.
|
Merging to trigger the nightly workflows. |
|
@rm3l: new pull request created: #2225 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |



Description
Fix the nightly checks that have been failing because this example manifest would not succeed in starting RHDH.
Which issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer
I checked locally that
make test-e2epasses:EDIT: Confirmed in the latest nightly run: https://github.com/redhat-developer/rhdh-operator/actions/runs/21434648352