-
Notifications
You must be signed in to change notification settings - Fork 88
chore: initial Qodo configuration #2181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| name: PR TOML Validator | ||
|
|
||
| on: | ||
| push: | ||
| paths: | ||
| - '**.toml' | ||
| pull_request: | ||
| paths: | ||
| - '**.toml' | ||
|
|
||
| jobs: | ||
| validate: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6 | ||
| - uses: tombi-toml/setup-tombi@f7cb38e77d9a62bc27a8445bf50e660e9496b893 # v1.0.7 | ||
| with: | ||
| version: 'v0.7.22' | ||
| checksum: '2f96342066b02ac374b2b457c9927264fd086256c1c6ccc817eced8367f1d83c' | ||
| - name: Validate TOML files | ||
| run: tombi lint |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| [jira] | ||
| jira_api_token = "${{ secrets.JIRA_API_TOKEN }}" | ||
| jira_base_url = "https://issues.redhat.com" | ||
|
|
||
| [github_app] | ||
| # what should be launched automatically | ||
| pr_commands = [ | ||
| "/review", | ||
| "/describe --pr_description.final_update_message=false", | ||
| "/improve", | ||
| ] | ||
| feedback_on_draft_pr = true | ||
|
|
||
| [pr_reviewer] # /review # | ||
| persistent_comment = true | ||
| require_tests_review = false | ||
| require_ticket_analysis_review = true | ||
| enable_review_labels_security = true | ||
| enable_review_labels_effort = true | ||
|
|
||
| [pr_description] # /describe # | ||
| enable_pr_diagram = false | ||
| publish_labels = true | ||
| final_update_message = true | ||
| # without this, it can interfere with Sourcery AI | ||
| publish_description_as_comment = true | ||
| publish_description_as_comment_persistent = true | ||
| add_original_user_description = false | ||
|
|
||
| [pr_code_suggestions] | ||
| commitable_code_suggestions = false | ||
|
|
||
| [config] | ||
| ignore_pr_authors = ["renovate", "rhdh-bot", "dependabot"] | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Skip for those bot PRs? |
||
|
|
||
| [rag_arguments] | ||
| enable_rag=true | ||
| rag_repo_list=['redhat-developer/rhdh','redhat-developer/red-hat-developers-documentation-rhdh'] | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any other repositories that are worth including in RAG for context? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this should suffice for now, better to start small and add more context as necessary rather than ending up with irrelevant observations from other repos. For future reference, do the repositories in this list need to also have Qodo enabled and configured? |
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also an option to use a Wiki for storing and periodically updating the best practices. We don't have it yet enabled for any other repository, but it can make sense to use it.
Please look here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The COPE team was discussing last week how Qodo would be useful in helping to review new plugin requests as there is a standard set of items to be checked for these PRs. I think this could be placed in a custom
best_practices.mdfile, but it seems like this can work in conjunction with the autogenerated one that is enabled with the Wiki. I can add the custom file in a subsequent PR and also look into adding the Wiki + autogenerated best practices.