fix: provide Catalog Graph API #3980
Conversation
Signed-off-by: Diana Janickova <djanicko@redhat.com>
|
Skipping CI for Draft Pull Request. |
|
The image is available at: /test e2e-ocp-helm |
Signed-off-by: Diana Janickova <djanicko@redhat.com>
djanickova
changed the title
|
The image is available at: /test e2e-ocp-helm |
Signed-off-by: Diana Janickova <djanicko@redhat.com>
Signed-off-by: Diana Janickova <djanicko@redhat.com>
Signed-off-by: Diana Janickova <djanicko@redhat.com>
|
The image is available at: /test e2e-ocp-helm |
|
/retest |
1 similar comment
|
/retest |
|
The image is available at: /test e2e-ocp-helm |
Signed-off-by: Diana Janickova <djanicko@redhat.com>
djanickova
changed the title
|
The image is available at: /test e2e-ocp-helm |
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
|
|
The image is available at: |
debsmita1
left a comment
debsmita1
left a comment
There was a problem hiding this comment.
We should create a spike to further look into this, so that we do not have to hardcode the custom relations. For now, this workaround should be fine
/lgtm
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debsmita1, polasudo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.9 |
|
@djanickova: only redhat-developer org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.9 |
|
@djanickova: new pull request created: #4084 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
Description
The dependency graph was not showing custom relations such as scaffoldedFrom/scaffolderOf. For now, we have agreed to create this simple fix and create a followup spike for it in Jira on how to solve this in a more complex way (so that the custom relations would not be hardcoded). The issue also caused the previous annotator e2e test to fail - I refactored the tests into 2 separate files so that they are related to the actual plugins responsible for them.
More details can be found in the Jira issue and its comments.
The fixed dependency graph:
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer