Skip to content

chore: clean up translation files #4051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ciiay wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: clean up translation files #4051

ciiay wants to merge 4 commits into from

Conversation

@ciiay
Copy link
Member

@ciiay ciiay commented Jan 23, 2026 •
edited
Loading

Description

Cleaned up translation files with latest it, ja and fr translation for backstage.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci bot requested review from kim-tsao and nickboldt January 23, 2026 06:02
karthikjeeyar
karthikjeeyar suggested changes Jan 23, 2026
View reviewed changes
translations/backstage-2026-01-08-ja.json Outdated
@@ -0,0 +1,731 @@
{
"api-docs": {
"en": {
Copy link
Member

@karthikjeeyar karthikjeeyar Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"en": {
"ja": {

This should be changed in all other places too.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

The image is available at:

@ciiay ciiay force-pushed the translation-support-clean-up branch from d4b41db to eb4d452 Compare January 23, 2026 16:47
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

The image is available at:

@ciiay ciiay force-pushed the translation-support-clean-up branch from eb4d452 to d8d8b3c Compare January 24, 2026 02:33
@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

The image is available at:

@ciiay ciiay force-pushed the translation-support-clean-up branch from d8d8b3c to 4564786 Compare January 26, 2026 21:38
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2026

The image is available at:

@ciiay ciiay force-pushed the translation-support-clean-up branch from 4564786 to 3207784 Compare January 27, 2026 02:10
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

The image is available at:

karthikjeeyar
karthikjeeyar reviewed Jan 27, 2026
View reviewed changes
Copy link
Member

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the PR changes using the PR image, looks good to me.

I have noticed a place where there is some manual correction needed. PTAL

translations/backstage-2026-01-08-fr.json Outdated
"fr": {
"catalogFilter.title": "Filtres",
"catalogFilter.buttonTitle": "Filtres",
"entityKindPicker.title": "Type",
Copy link
Member

@karthikjeeyar karthikjeeyar Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not translated in french and also it has incorrect value "Type" instead of "Kind" and Ideally this should be translated (Maybe we can use AI for this for now).

Suggested change
"entityKindPicker.title": "Type",
"entityKindPicker.title": "Kind",
image

Copy link
Member Author

@ciiay ciiay Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @karthikjeeyar , the "Type" is already a translated word. The thing is in French both "kind" and "type" are "type". I consulted AI regarding translation of

"entityTypePicker.title": "Type", 
"entityKindPicker.title": "Kind",

when they are together, AI suggested

"entityTypePicker.title": "Type",
"entityKindPicker.title": "Catégorie"

As in Backstage, Kind and Type have different meanings:

  • Kind = entity category (Component, API, Resource, System, Group, User…)
  • Type = subtype within a Kind (service, website, library…)

What do you think? If it looks good to you, I will go ahead and update other similar cases to keep everything consistent in French.

  • Treat Kind = high-level entity classification: Entity class (Component, API, Resource…)
  • Treat Type = subtype / functional type: Subtype (service, website…)

Copy link
Member

@karthikjeeyar karthikjeeyar Jan 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Let us use AI suggested translation "Catégorie" to differentiate those headings.

@ciiay ciiay force-pushed the translation-support-clean-up branch from fe9ac37 to dc78186 Compare January 27, 2026 16:49
@karthikjeeyar
Copy link
Member

karthikjeeyar commented Jan 27, 2026

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 27, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

The image is available at:

@ciiay ciiay force-pushed the translation-support-clean-up branch from dc78186 to e515b1c Compare January 27, 2026 20:07
@openshift-ci openshift-ci bot removed the lgtm label Jan 27, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

The image is available at:

@ciiay ciiay force-pushed the translation-support-clean-up branch from e515b1c to 3f6c753 Compare January 27, 2026 22:18
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

The image is available at:

@ciiay ciiay force-pushed the translation-support-clean-up branch from 3f6c753 to 6b4fc43 Compare January 28, 2026 02:43
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

The image is available at:

@ciiay
Copy link
Member Author

ciiay commented Jan 28, 2026

/test e2e-ocp-helm

@rhdh-qodo-merge
Copy link

rhdh-qodo-merge bot commented Jan 28, 2026 

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan
ⓘ Paying users. Check that your Qodo account is linked with this Git user account

@karthikjeeyar
Copy link
Member

karthikjeeyar commented Jan 28, 2026

/retest

1 similar comment
@invincibleJai
Copy link
Member

invincibleJai commented Jan 28, 2026

/retest

ciiay added 3 commits January 28, 2026 08:49
@ciiay
chore: clean up translation files
9366d8e 
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay
addressed review feedback
e2176e2 
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay
updated fr translation and added a missing rbac key
d37e2d6 
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay ciiay force-pushed the translation-support-clean-up branch from 6b4fc43 to d37e2d6 Compare January 28, 2026 13:49
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

The image is available at:

@ciiay ciiay mentioned this pull request Jan 28, 2026
Open
5 tasks
@ciiay
fixed e2e tests
da8051e 
Signed-off-by: Yi Cai <yicai@redhat.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 28, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

The image is available at:

karthikjeeyar
karthikjeeyar approved these changes Jan 28, 2026
View reviewed changes
Copy link
Member

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 28, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karthikjeeyar
Once this PR has been reviewed and has the lgtm label, please assign alizard0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ciiay
Copy link
Member Author

ciiay commented Jan 28, 2026

/cherry-pick release-1.9

@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Jan 28, 2026

@ciiay: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@christoph-jerolimov
Copy link
Member

christoph-jerolimov commented Jan 28, 2026

@ciiay @karthikjeeyar Thanks a lot.

But can you please remove the date / version inforation from the filenames? This makes it impossible currently to understand the diff (yeah I can use diff locally but I like to understand this on GitHub).

Also this would require us to change ts import every time we update the json files.

This change also means we're losing translations for all BCP plugins that are not from Red Hat but supports translations, right?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kim-tsao kim-tsao Awaiting requested review from kim-tsao

@nickboldt nickboldt Awaiting requested review from nickboldt

1 more reviewer

@karthikjeeyar karthikjeeyar karthikjeeyar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karthikjeeyar karthikjeeyar

Labels

lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ciiay @karthikjeeyar @invincibleJai @openshift-cherrypick-robot @christoph-jerolimov