-
Notifications
You must be signed in to change notification settings - Fork 214
fix(e2e): attempt to move rbac conditions from initContainer #4075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
The image is available at: |
9f02819 to
5c16a89
Compare
|
The image is available at: |
5c16a89 to
35adcd3
Compare
35adcd3 to
c2a5407
Compare
|
The image is available at: |
|
/retest |
1 similar comment
|
/retest |
c2a5407 to
f058622
Compare
|
/test e2e-eks-helm-nightly |
ⓘ Your monthly quota for Qodo has expired. Upgrade your plan ⓘ Paying users. Check that your Qodo account is linked with this Git user account |
|
The image is available at: |
|
/test e2e-aks-helm-nightly |
ⓘ Your monthly quota for Qodo has expired. Upgrade your plan ⓘ Paying users. Check that your Qodo account is linked with this Git user account |
|
/test e2e-ocp-helm |
ⓘ Your monthly quota for Qodo has expired. Upgrade your plan ⓘ Paying users. Check that your Qodo account is linked with this Git user account |
f058622 to
1ae7760
Compare
|
@PatAKnight: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: Patrick Knight <pknight@redhat.com>
1ae7760 to
fc0f9b6
Compare
|



Description
Removes the rbac conditional policy file creation from the init container. Instead, we add it to the
rbac-policies.yamlfile which is already being added to the cluster and added to the helm chartWhich issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer