Skip to content

Conversation

@PatAKnight
Copy link
Member

Description

Removes the rbac conditional policy file creation from the init container. Instead, we add it to the rbac-policies.yaml file which is already being added to the cluster and added to the helm chart

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign alizard0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@PatAKnight
Copy link
Member Author

/retest

1 similar comment
@PatAKnight
Copy link
Member Author

/retest

@PatAKnight
Copy link
Member Author

/test e2e-eks-helm-nightly
/test e2e-eks-operator-nightly

@rhdh-qodo-merge
Copy link

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan
ⓘ Paying users. Check that your Qodo account is linked with this Git user account

@github-actions
Copy link
Contributor

@PatAKnight
Copy link
Member Author

/test e2e-aks-helm-nightly
/test e2e-aks-operator-nightly

@rhdh-qodo-merge
Copy link

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan
ⓘ Paying users. Check that your Qodo account is linked with this Git user account

@PatAKnight
Copy link
Member Author

/test e2e-ocp-helm

@rhdh-qodo-merge
Copy link

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan
ⓘ Paying users. Check that your Qodo account is linked with this Git user account

@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

@PatAKnight: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-eks-helm-nightly f058622 link false /test e2e-eks-helm-nightly
ci/prow/e2e-eks-operator-nightly f058622 link false /test e2e-eks-operator-nightly
ci/prow/e2e-aks-operator-nightly f058622 link false /test e2e-aks-operator-nightly
ci/prow/e2e-aks-helm-nightly f058622 link false /test e2e-aks-helm-nightly
ci/prow/e2e-ocp-helm 1ae7760 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Signed-off-by: Patrick Knight <pknight@redhat.com>
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant