Tracing fix v2 #351
Open
Tracing fix v2 #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Record span parent and provide helper methods to navigate span hierarchies.
mmatczuk
force-pushed
the
mmt/tracing_fix_v2
branch
from
65480eb to
7a01b85
Compare
mmatczuk
force-pushed
the
mmt/tracing_fix_v2
branch
from
e4f3977 to
0360192
Compare
Do not discard instrumented messages returned by tracing.WithChildSpan(...) and restore original context when done.
mmatczuk
force-pushed
the
mmt/tracing_fix_v2
branch
from
0360192 to
427670e
Compare
Based on https://opentelemetry.io/docs/specs/semconv/http/http-spans/ - `http.request.method` - HTTP method (GET, POST, PUT, etc.) - `url.full` - Complete request URL - `server.address` - Hostname from URL - `server.port` - Port number (only if explicitly specified in URL) - `network.protocol.version` - HTTP version (HTTP/1.1, etc.) - `url.scheme` - URL scheme (http/https) - `user_agent.original` - User-Agent header value (if present) - `http.response.status_code` - HTTP status code (200, 404, etc.) - `error.type` - Error classification (status code, "timeout", "canceled", "request_error") - `http.request.resend_count` - Number of retry attempts
mmatczuk
force-pushed
the
mmt/tracing_fix_v2
branch
from
c06856e to
dc01f5b
Compare
weeco
approved these changes
Jan 22, 2026
josephwoodward
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the invalid parent child relationship in spans. With this patch the spans are rendered correctly
