Open
Conversation
gene-redpanda
force-pushed
the
test-sysctl
branch
from
54bc9fc to
8715f36
Compare
gene-redpanda
force-pushed
the
test-sysctl
branch
from
113b64f to
77b3f30
Compare
gene-redpanda
force-pushed
the
test-sysctl
branch
from
232b789 to
9ae1ace
Compare
gene-redpanda
force-pushed
the
test-sysctl
branch
from
9ae1ace to
7a1dce7
Compare
chrisseto
approved these changes
Oct 8, 2025
|
|
||
| vars: | ||
| ARTIFACT_DIR: "{{.PWD}}/artifacts" | ||
| DEPLOYMENT_ID: '{{.DEPLOYMENT_ID | default "devex-cicd"}}' |
There was a problem hiding this comment.
I see this defined and some other variables with the same definitions multiple times (and sometimes not used). Is that intentional? If not would it be better to move share variables into Taskfile.yml at the top level?
| - | | ||
| OS=$(uname) | ||
| if [ "$OS" = "Darwin" ]; then | ||
| curl -L {{.MAC_RPK}} -o {{.ARTIFACT_DIR}}/tmp/rpk.zip |
There was a problem hiding this comment.
Just my two cents, I find it better to put non-local variables into the scope of the task so it's clear what is local to this task and what's expected to be shared.
gene-redpanda
force-pushed
the
test-sysctl
branch
from
a258733 to
78c4e69
Compare
When run during the connect test without this particular method of testing for the existence of keys the connect test fails.
gene-redpanda
force-pushed
the
test-sysctl
branch
from
78c4e69 to
7d3f336
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates various clients and tooling in the repo and moves us to task from make to bring the repo into alignment with the k8s operator.