Improve performance of removing elements from sequences#307
Open
jeff303 wants to merge 1 commit intoredplanetlabs:masterfrom
Open
Improve performance of removing elements from sequences#307jeff303 wants to merge 1 commit intoredplanetlabs:masterfrom
jeff303 wants to merge 1 commit intoredplanetlabs:masterfrom
Conversation
Contributor
Author
|
I think this change should also cover |
3a59e44 to
b1b952a
Compare
Contributor
Author
|
This should cover most of #219, although it doesn't do anything to address |
Merging `InsertBeforeIndex` protocol into new `IndexedOps` protocol for optimized indexed based operations (which now includes inserting before and removing at) Updating `nthpath` and `keypath` to use new helper fns Adding tests and benchmarks
b1b952a to
2ace3be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging
InsertBeforeIndexprotocol into newIndexedOpsprotocol for optimized indexed based operations (which now includes inserting before and removing at)Updating
nthpathandkeypathto use new helper fnsAdding tests and benchmarks