This repository was archived by the owner on Sep 3, 2025. It is now read-only.
[IPF-87-1] DKIM record validation updated in ParsePublicKey(). #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves DKIM record parsing and validation and enhances error handling.
1. New Error Definitions
The patch introduces explicit error constants to improve clarity and debugging:
ErrEmptyRecord: Indicates an empty DKIM record.ErrUnsupportedVersion: Indicates an unsupported DKIM record version.ErrUnsupportedAlgorithm: Indicates an unsupported algorithm in DKIM.ErrDecodeBase64: Indicates errors during base64 decoding.ErrParsePublicKey: Indicates failures during public key parsing.ErrUnsupportedServices: Indicates unsupported service types listed in the DKIM key.ErrMissedPTag: Indicates the absence of the mandatoryptag.2. Improvements in
ParsePublicKeyMultiple Error Reporting:
The function now collects and returns multiple errors encountered during parsing instead of halting after the first error.
Updated Function Signature:
ParsePublicKeyreturns a slice of errors ([]error) instead of a single error.