Skip to content
This repository was archived by the owner on Sep 2, 2025. It is now read-only.

fix(parser): correctly handle redirect in inspect mode #32

Merged
dmotylev merged 1 commit into from
May 8, 2025
Merged

fix(parser): correctly handle redirect in inspect mode #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ type unused struct {
}

func (p *parser) observe(tokens []*token) (Result, string, unused, error) {
mechanisms, _, _, unknownModifiers, err := sortTokens(tokens)
mechanisms, _, _, _, err := sortTokens(tokens)
if err != nil {
return Permerror, "", unused{mechanisms, nil}, err
}
Expand Down Expand Up @@ -305,10 +305,6 @@ func (p *parser) observe(tokens []*token) (Result, string, unused, error) {
// others are being registered by listener
}

for i, token = range unknownModifiers {
p.fireDirective(token, "")
}

return unreliableResult, "", unused{}, ErrUnreliableResult
}

Expand Down Expand Up @@ -842,10 +838,6 @@ func (p *parser) handleRedirect(t *token) (Result, error) {
redirectDomain := NormalizeFQDN(domain)

p.fireDirective(t, redirectDomain)
if p.ignoreMatches {
// In inspect mode we only register modifier presence, w/o actual handling
return unreliableResult, ErrUnreliableResult
}

if err != nil {
return Permerror, NewSpfError(spferr.KindSyntax, err, t)
Expand Down