Deprecate 8.0 and tests for PHP 8.3, 8.4 & 8.5 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
There was a problem hiding this comment.
Pull request overview
This PR updates the minimum PHP version requirement from 8.0 to 8.1, adds test coverage for newer PHP versions (8.3, 8.4, 8.5), and improves type safety by adding proper generic type annotations to the Iterator implementation.
- Bumps minimum PHP version from 8.0 to 8.1 in composer.json
- Adds testing for PHP 8.3, 8.4, and 8.5 while removing 8.0 from the test matrix
- Adds proper generic type annotations for Iterator interface and removes obsolete PHPStan configuration
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| composer.json | Updates PHP version requirements from ^8.0 to ^8.1 in both require and platform config |
| .github/workflows/test.yml | Adds PHP 8.3, 8.4, and 8.5 to the test matrix and removes 8.0 |
| src/BinaryFlags.php | Adds generic type annotation @implements Iterator<int|float, string> to properly document Iterator implementation |
| phpstan.neon.dist | Removes checkGenericClassInNonGenericObjectType setting now that proper generic types are specified |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.