-
Notifications
You must be signed in to change notification settings - Fork 9
Update remote if url has changed #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update remote if url has changed #34
Conversation
jguiditta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MInor wording suggestions, otherwise this seems fine to me. I do wonder if perhaps we should bump the version of git_wrapper dep though. Then we can do a 2.3 release over there to add the new method in your patch, and guarantee this will get the expected functionality.
73108b2 to
40c0c49
Compare
Any thought on making git_wrapper version dependency be 2.3 to guarantee the expected feature is there? Also, I think we should do that release before merging to, to avoid any issues. |
40c0c49 to
44eab91
Compare
Done! |
jguiditta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, this looks good to me! I'll tag git_wrapper so it does a build as soon as that patch merges
jguiditta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized - git_wrapper is already tagged up to0.2.10, so we should make this require 0.2.11
44eab91 to
ebaecff
Compare
Previously we were checking if the remote name is there to add it. Now, if the patches_repo url has changed, but we maintain the same remote_name, this is updated. For doing this, we just check if the remote_name exists and if the patches_repo differs from its value. If so, we just remove the remote so next line below it'd recreate it. Not it's based on new git_wrapper version that allows to return the remote dict with its value but also to remove the remote. Requires: release-depot/git_wrapper#114
ebaecff to
b3badb7
Compare
|
recheck |
eggmaster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Previously we were checking if the remote name is there to add it. Now, if the patches_repo url has changed, but we maintain the same remote_name, this is updated.
For doing this, we just check if the remote_name exists and if the patches_repo differs from its value. If so, we just remove the remote so next line below it'd recreate it.
Not it's based on new git_wrapper version that allows to return the remote dict with its value but also to remove the remote.
Requires: release-depot/git_wrapper#114