Add 'wsl' format for wsl2 images #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WSL images can now literally have the format .wsl, according to Neal and Yaakov. This is fine. So let's allow it. See: https://pagure.io/pungi/pull-request/1841 Signed-off-by: Adam Williamson <awilliam@redhat.com>
Contributor
Author
Conan-Kudo
reviewed
Jul 4, 2025
| 'vsphere-ova': ['vsphere.ova'], | ||
| # https://learn.microsoft.com/en-us/windows/wsl/use-custom-distro | ||
| 'wsl2': ['tar', 'tar.gz'], | ||
| 'wsl2': ['tar', 'tar.gz', 'wsl'], |
Contributor
There was a problem hiding this comment.
wsl never officially supported tar and tar.gz, so we should eventually drop those.
Conan-Kudo
approved these changes
Jul 4, 2025
yselkowitz
approved these changes
Jul 4, 2025
yselkowitz
left a comment
yselkowitz
left a comment
There was a problem hiding this comment.
This change together with the latest pungi release successfully adds wsl2 images to the compose output.
Contributor
|
Thanks for the patch. I tagged a new release, but since the patch has been backported to Fedora already, I'll hold off on making new builds. |
|
We're also tracking the removal of six deps from rawhide and ELN so 1.46 would be helpful at least in rawhide. |
Contributor
Contributor
Author
|
I bet you never guessed that would break anaconda...:P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WSL images can now literally have the format .wsl, according to Neal and Yaakov. This is fine. So let's allow it.
See: https://pagure.io/pungi/pull-request/1841