Improve HTTP requests sent by the library #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code did a full GET request to download the entire file and then threw the data away. Not great. Assisted-By: Claude Code
If the same program wants to check the same path or url multiple times, let's not repeat the possibly expensive HTTP request. Assisted-By: Claude Code
The actual value can be overriden by any code using the library by setting `productmd.common.USER_AGENT`. Assisted-By: Claude Code
We are only interested in JSON, we can as well tell the server about it. Assisted-By: Claude Code
Contributor
|
LGTM. |
|
please release this fix soon - linux-system-roles CI is broken due to this - see https://github.com/linux-system-roles/firewall/actions/runs/19936654882/job/57163293637?pr=310 |
Contributor
Author
|
The release is on PyPI for a while already. I made new Fedora builds though: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes network requests made by productmd:
_file_exists()to prevent redundant network requestsUser-Agent: productmd/<VERSION>andAccept: application/json