-
Notifications
You must be signed in to change notification settings - Fork 0
Update .NET dependencies: .NET 8.0: 8.0.22 -> 8.0.23, .NET 9.0: 9.0.11 -> 9.0.12, .NET 10.0: 10.0.0 -> 10.0.2 #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughBumps .NET patch versions in installer and docs: updates to 8.0 (8.0.22→8.0.23), 9.0 (9.0.11→9.0.12), and 10.0 (10.0.0→10.0.2) across install checks, runtime/ASP.NET Core/Windows Desktop titles, and x86/x64 download URLs in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
83-83: .NET 10.0.1 README entry matches code; consider markdown indent if lint is enforcedThe new “.NET 10.0.1 (Runtime, ASP.NET, Desktop)” entry is consistent with the dependency functions in
CodeDependencies.iss.
markdownlint (MD007) flags this line’s list indentation (4 spaces vs expected 2). If your pipeline enforces MD007 on changed lines, consider adjusting this bullet’s indent (or updating the rule/config) to keep lint clean.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
CodeDependencies.iss(1 hunks)README.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md
83-83: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
🔇 Additional comments (3)
CodeDependencies.iss (3)
554-559: .NET 10.0 runtime bump is consistent across check, title, and URLs
Dependency_AddDotNet100now checks forMicrosoft.NETCore.App10.0.1 and installs.NET Runtime 10.0.1from 10.0.1 x86/x64 URLs. This matches the pattern used for 8.0 and 9.0 and looks internally consistent.If you want an extra safety check, re-run the “Check .NET Updates” workflow or curl the new 10.0.1 runtime URLs to confirm they resolve as expected.
566-571: ASP.NET Core 10.0 runtime bump matches the runtime pattern
Dependency_AddDotNet100Aspnow targetsMicrosoft.AspNetCore.App10.0.1, updates the title to “ASP.NET Core Runtime 10.0.1”, and points to 10.0.1 aspnetcore x86/x64 URLs. This is aligned with the non-ASP.NET block and earlier version patterns.Same as above, you may want to confirm the aspnetcore 10.0.1 URLs (and presence in
releases-index.json) via your existing update workflow.
578-583: Desktop 10.0 runtime bump is aligned with other 10.0.1 entries
Dependency_AddDotNet100Desktopnow checks forMicrosoft.WindowsDesktop.App10.0.1, uses the “.NET Desktop Runtime 10.0.1” title, and references the corresponding WindowsDesktop 10.0.1 x86/x64 installers. This keeps the desktop runtime in sync with the core and ASP.NET runtimes.As with the other 10.0.1 blocks, rely on your “Check .NET Updates” automation or a quick URL check to ensure the WindowsDesktop 10.0.1 links remain valid.
…1 -> 9.0.12, .NET 10.0: 10.0.0 -> 10.0.2
a9fc3c7 to
ff396e5
Compare
This PR updates the .NET runtime dependencies.
Updates
.NET 8.0: 8.0.22 -> 8.0.23, .NET 9.0: 9.0.11 -> 9.0.12, .NET 10.0: 10.0.0 -> 10.0.2
EOL Versions Marked
None
The following files have been updated:
CodeDependencies.iss- Updated versions (EOL versions kept for compatibility)README.md- Updated version documentation and marked EOL entriesExampleSetup.iss- EOL version function calls commented out with EOL markers for discoverabilityThis PR was automatically created by the Check .NET Updates workflow.