fix: uses correct address in bip122 signmessage #953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
8 Skipped Deployments
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the BIP122 signMessage method where incorrect address references were being used. The fix ensures the method uses the correct address parameter passed to the function, aligning with the pattern used by other BIP122 methods.
Key changes:
- Removed broken logic that referenced an out-of-scope
accounts[0]variable - Changed the
accountparameter from usinggetAddressFromAccount(accounts[0])to using the function'saddressparameter - Simplified the
addressparameter to always use the function'saddressparameter instead of conditional logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the BIP122 signMessage method where incorrect address references were being used. The fix ensures the method uses the correct address parameter passed to the function, aligning with the pattern used by other BIP122 methods.
Key changes: