Skip to content

[RUN-1730] hashtable: make it ordered #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
oridb wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

[RUN-1730] hashtable: make it ordered #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e5de1a7
hashtable: make it ordered
oridb May 2, 2023
33207f5
fixes
oridb May 4, 2023
364ffb0
Move back to vector based backing
oridb May 10, 2023
517e871
fix hashset swap
oridb May 10, 2023
01e56d3
compress the ordering vector if it grows too much
oridb May 10, 2023
fb32195
revert test changes
oridb May 10, 2023
39e0b2d
missed revert
oridb May 10, 2023
c322427
revert to gc'ed arrays
oridb May 11, 2023
d002b51
fix some missing count copies
oridb May 15, 2023
e1bdc6d
Merge branch 'master' of github.com:replayio/chromium into run1730-st…
Domiii May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions third_party/blink/renderer/platform/wtf/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ visibility = [
]

config("wtf_config") {
cflags = ["-g", "-O0"]
if (is_win) {
cflags = [
# Don't complain about calling specific versions of templatized
Expand Down Expand Up @@ -340,6 +341,7 @@ source_set("wtf_unittests_sources") {
"vector_test.cc",
]

cflags = ["-g", "-O0"]
if (is_win) {
cflags = [ "/wd4068" ] # Unknown pragma.
}
Expand Down
20 changes: 20 additions & 0 deletions third_party/blink/renderer/platform/wtf/hash_map_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,26 @@ TEST(HashMapTest, Iteration) {
EXPECT_EQ((1 << 10) - 1, encountered_keys);
}

TEST(HashMapTest, OrderedIteration) {
IntHashMap map;
for (int i = 0; i < 10; ++i)
map.insert(1 << i, i);

int i = 0;
for (auto it = map.begin(); it != map.end(); ++it) {
EXPECT_EQ(it->key, 1<<i);
EXPECT_EQ(it->value, i);
i++;
}
i = 10;
for (auto it = map.end(); it != map.begin();) {
--it;
--i;
EXPECT_EQ(it->key, 1<<i);
EXPECT_EQ(it->value, i);
}
}

struct TestDoubleHashTraits : HashTraits<double> {
static const unsigned kMinimumTableSize = 8;
};
Expand Down
Loading