Drop Python 3.8 support

coglet/python/tests/schemas/cog.yaml

@@ -1,3 +1,3 @@
 build:
-  python_version: "3.8"
+  python_version: "3.9"
 predict: "predict.py:Predictor"

docs/llms.txt

@@ -2405,7 +2405,7 @@ build:
   python_version: "3.11.1"
 ```
 
-Cog supports all active branches of Python: 3.8, 3.9, 3.10, 3.11, 3.12, 3.13. If you don't define a version, Cog will use the latest version of Python 3.12 or a version of Python that is compatible with the versions of PyTorch or TensorFlow you specify.
+Cog supports all active branches of Python: 3.9, 3.10, 3.11, 3.12, 3.13. If you don't define a version, Cog will use the latest version of Python 3.12 or a version of Python that is compatible with the versions of PyTorch or TensorFlow you specify.
 
 Note that these are the versions supported **in the Docker container**, not your host machine. You can run any version(s) of Python you wish on your host machine.
 

docs/yaml.md

@@ -115,7 +115,7 @@ build:
   python_version: "3.11.1"
 ```
 
-Cog supports all active branches of Python: 3.8, 3.9, 3.10, 3.11, 3.12, 3.13. If you don't define a version, Cog will use the latest version of Python 3.12 or a version of Python that is compatible with the versions of PyTorch or TensorFlow you specify.
+Cog supports all active branches of Python: 3.9, 3.10, 3.11, 3.12, 3.13. If you don't define a version, Cog will use the latest version of Python 3.12 or a version of Python that is compatible with the versions of PyTorch or TensorFlow you specify.
 
 Note that these are the versions supported **in the Docker container**, not your host machine. You can run any version(s) of Python you wish on your host machine.
 

pkg/config/config.go

@@ -31,7 +31,7 @@ var (
 
 const (
 	MinimumMajorPythonVersion               int = 3
-	MinimumMinorPythonVersion               int = 8
+	MinimumMinorPythonVersion               int = 9 // Python 3.8 EOL October 2024
 	MinimumMinorPythonVersionForConcurrency int = 11
 	MinimumMajorCudaVersion                 int = 11
 )

pkg/config/config_test.go

@@ -25,7 +25,7 @@ func TestValidateModelPythonVersion(t *testing.T) {
 		},
 		{
 			name:          "MinimumVersion",
-			pythonVersion: "3.8",
+			pythonVersion: "3.9",
 		},
 		{
 			name:           "MinimumVersionForConcurrency",
@@ -34,9 +34,9 @@ func TestValidateModelPythonVersion(t *testing.T) {
 		},
 		{
 			name:           "TooOldForConcurrency",
-			pythonVersion:  "3.8",
+			pythonVersion:  "3.9",
 			concurrencyMax: 5,
-			expectedErr:    "when concurrency.max is set, minimum supported Python version is 3.11. requested 3.8",
+			expectedErr:    "when concurrency.max is set, minimum supported Python version is 3.11. requested 3.9",
 		},
 		{
 			name:          "FullyQualifiedVersion",
@@ -54,8 +54,8 @@ func TestValidateModelPythonVersion(t *testing.T) {
 		},
 		{
 			name:          "LessThanMinimum",
-			pythonVersion: "3.7",
-			expectedErr:   "minimum supported Python version is 3.8. requested 3.7",
+			pythonVersion: "3.8",
+			expectedErr:   "minimum supported Python version is 3.9. requested 3.8",
 		},
 	}
 
@@ -154,7 +154,7 @@ func assertMinorVersion(t *testing.T, expected, actual string) {
 func TestPythonPackagesAndRequirementsCantBeUsedTogether(t *testing.T) {
 	config := &Config{
 		Build: &Build{
-			PythonVersion: "3.8",
+			PythonVersion: "3.9",
 			PythonPackages: []string{
 				"replicate==1.0.0",
 			},
@@ -177,7 +177,7 @@ foo==1.0.0`), 0o644)
 	config := &Config{
 		Build: &Build{
 			GPU:                true,
-			PythonVersion:      "3.8",
+			PythonVersion:      "3.9",
 			PythonRequirements: "requirements.txt",
 		},
 	}
@@ -207,7 +207,7 @@ foo==1.0.0`), 0o644)
 	config := &Config{
 		Build: &Build{
 			GPU:                true,
-			PythonVersion:      "3.8",
+			PythonVersion:      "3.9",
 			PythonRequirements: "requirements.txt",
 		},
 	}
@@ -242,7 +242,7 @@ flask>0.4
 	config := &Config{
 		Build: &Build{
 			GPU:                true,
-			PythonVersion:      "3.8",
+			PythonVersion:      "3.9",
 			PythonRequirements: "requirements.txt",
 		},
 	}
@@ -264,7 +264,7 @@ func TestValidateAndCompleteCUDAForAllTF(t *testing.T) {
 		config := &Config{
 			Build: &Build{
 				GPU:           true,
-				PythonVersion: "3.8",
+				PythonVersion: "3.9",
 				PythonPackages: []string{
 					"tensorflow==" + compat.TF,
 				},
@@ -283,7 +283,7 @@ func TestValidateAndCompleteCUDAForAllTorch(t *testing.T) {
 		config := &Config{
 			Build: &Build{
 				GPU:           compat.CUDA != nil,
-				PythonVersion: "3.8",
+				PythonVersion: "3.9",
 				PythonPackages: []string{
 					"torch==" + compat.TorchVersion(),
 				},
@@ -315,7 +315,7 @@ func TestValidateAndCompleteCUDAForSelectedTorch(t *testing.T) {
 		config := &Config{
 			Build: &Build{
 				GPU:           true,
-				PythonVersion: "3.8",
+				PythonVersion: "3.9",
 				PythonPackages: []string{
 					"torch==" + tt.torch,
 				},
@@ -338,7 +338,7 @@ func TestUnsupportedTorch(t *testing.T) {
 	config := &Config{
 		Build: &Build{
 			GPU:           true,
-			PythonVersion: "3.8",
+			PythonVersion: "3.9",
 			PythonPackages: []string{
 				"torch==0.4.1",
 			},
@@ -375,7 +375,7 @@ func TestUnsupportedTensorflow(t *testing.T) {
 	config := &Config{
 		Build: &Build{
 			GPU:           true,
-			PythonVersion: "3.8",
+			PythonVersion: "3.9",
 			PythonPackages: []string{
 				"tensorflow==0.4.1",
 			},
@@ -389,7 +389,7 @@ func TestUnsupportedTensorflow(t *testing.T) {
 		Build: &Build{
 			GPU:           true,
 			CUDA:          "11.8",
-			PythonVersion: "3.8",
+			PythonVersion: "3.9",
 			PythonPackages: []string{
 				"tensorflow==0.4.1",
 			},
@@ -405,7 +405,7 @@ func TestPythonPackagesForArchTorchGPU(t *testing.T) {
 	config := &Config{
 		Build: &Build{
 			GPU:           true,
-			PythonVersion: "3.8",
+			PythonVersion: "3.9",
 			PythonPackages: []string{
 				"torch==1.7.1",
 				"torchvision==0.8.2",
@@ -434,7 +434,7 @@ func TestPythonPackagesForArchTorchCPU(t *testing.T) {
 	config := &Config{
 		Build: &Build{
 			GPU:           false,
-			PythonVersion: "3.8",
+			PythonVersion: "3.9",
 			PythonPackages: []string{
 				"torch==1.7.1",
 				"torchvision==0.8.2",
@@ -461,7 +461,7 @@ func TestPythonPackagesForArchTensorflowGPU(t *testing.T) {
 	config := &Config{
 		Build: &Build{
 			GPU:           true,
-			PythonVersion: "3.8",
+			PythonVersion: "3.9",
 			PythonPackages: []string{
 				"tensorflow==2.12.0",
 				"foo==1.0.0",
@@ -516,7 +516,7 @@ func TestCUDABaseImageTag(t *testing.T) {
 	config := &Config{
 		Build: &Build{
 			GPU:           true,
-			PythonVersion: "3.8",
+			PythonVersion: "3.9",
 			PythonPackages: []string{
 				"tensorflow==2.12.0",
 			},
@@ -640,7 +640,7 @@ func TestTorchWithExistingExtraIndexURL(t *testing.T) {
 	config := &Config{
 		Build: &Build{
 			GPU:           true,
-			PythonVersion: "3.8",
+			PythonVersion: "3.9",
 			PythonPackages: []string{
 				"torch==1.12.1 --extra-index-url=https://download.pytorch.org/whl/cu116",
 			},
@@ -670,7 +670,7 @@ func TestPythonRequirementsForArchWithAddedPackage(t *testing.T) {
 	config := &Config{
 		Build: &Build{
 			GPU:           true,
-			PythonVersion: "3.8",
+			PythonVersion: "3.9",
 			PythonPackages: []string{
 				"torch==2.4.0 --extra-index-url=https://download.pytorch.org/whl/cu116",
 			},
@@ -739,7 +739,7 @@ func TestAbsolutePathInPythonRequirements(t *testing.T) {
 	config := &Config{
 		Build: &Build{
 			GPU:                true,
-			PythonVersion:      "3.8",
+			PythonVersion:      "3.9",
 			PythonRequirements: requirementsFilePath,
 		},
 	}

pkg/config/load_test.go

@@ -10,7 +10,7 @@ import (
 
 const testConfig = `
 build:
-  python_version: "3.8"
+  python_version: "3.9"
   python_requirements: requirements.txt
   system_packages:
     - libgl1-mesa-glx

pkg/config/validator_test.go

@@ -10,7 +10,7 @@ func TestValidateConfig(t *testing.T) {
 	config := &Config{
 		Build: &Build{
 			GPU:           true,
-			PythonVersion: "3.8",
+			PythonVersion: "3.9",
 			PythonPackages: []string{
 				"tensorflow==1.15.0",
 				"foo==1.0.0",
@@ -28,7 +28,7 @@ func TestValidateSuccess(t *testing.T) {
   system_packages:
     - "libgl1-mesa-glx"
     - "libglib2.0-0"
-  python_version: "3.8"
+  python_version: "3.9"
   python_packages:
     - "torch==1.8.1"`
 
@@ -56,7 +56,7 @@ func TestValidateBuildIsRequired(t *testing.T) {
   system_packages:
     - "libgl1-mesa-glx"
     - "libglib2.0-0"
-  python_version: "3.8"
+  python_version: "3.9"
   python_packages:
     - "torch==1.8.1"`
 
@@ -68,7 +68,7 @@ func TestValidateBuildIsRequired(t *testing.T) {
 func TestValidatePythonVersionIsRequired(t *testing.T) {
 	config := `build:
   gpu: true
-  python_versions: "3.8"
+  python_versions: "3.9"
   system_packages:
     - "libgl1-mesa-glx"
     - "libglib2.0-0"
@@ -83,7 +83,7 @@ func TestValidatePythonVersionIsRequired(t *testing.T) {
 func TestValidateNullListsAllowed(t *testing.T) {
 	config := `build:
   gpu: true
-  python_version: "3.8"
+  python_version: "3.9"
   system_packages:
   python_packages:
   run:`

pkg/dockerfile/base.go

@@ -14,7 +14,7 @@ import (
 )
 
 const MinimumCUDAVersion = "11.6"
-const MinimumPythonVersion = "3.8"
+const MinimumPythonVersion = "3.9" // Python 3.8 EOL October 2024
 const MinimumTorchVersion = "1.13.1"
 const CogBaseImageName = "cog-base"
 

pkg/dockerfile/base_test.go

@@ -18,16 +18,16 @@ func TestBaseImageName(t *testing.T) {
 		torch    string
 		expected string
 	}{
-		{"", "3.8", "",
-			"r8.im/cog-base:python3.8"},
-		{"", "3.8", "2.1",
-			"r8.im/cog-base:python3.8-torch2.1.2"},
-		{"12.1", "3.8", "",
-			"r8.im/cog-base:cuda12.1-python3.8"},
-		{"12.1", "3.8", "2.1",
-			"r8.im/cog-base:cuda12.1-python3.8-torch2.1.2"},
-		{"12.1", "3.8", "2.1",
-			"r8.im/cog-base:cuda12.1-python3.8-torch2.1.2"},
+		{"", "3.9", "",
+			"r8.im/cog-base:python3.9"},
+		{"", "3.9", "2.1",
+			"r8.im/cog-base:python3.9-torch2.1.2"},
+		{"12.1", "3.9", "",
+			"r8.im/cog-base:cuda12.1-python3.9"},
+		{"12.1", "3.9", "2.1",
+			"r8.im/cog-base:cuda12.1-python3.9-torch2.1.2"},
+		{"12.1", "3.9", "2.1",
+			"r8.im/cog-base:cuda12.1-python3.9-torch2.1.2"},
 	} {
 		actual := BaseImageName(tt.cuda, tt.python, tt.torch)
 		require.Equal(t, tt.expected, actual)
@@ -36,7 +36,7 @@ func TestBaseImageName(t *testing.T) {
 
 func TestGenerateDockerfile(t *testing.T) {
 	cudaVersion := "12.1"
-	pythonVersion := "3.8"
+	pythonVersion := "3.9"
 	torchVersion := "2.1.0"
 	client := registrytest.NewMockRegistryClient()
 	client.AddMockImage(BaseImageName(cudaVersion, pythonVersion, torchVersion))
@@ -57,8 +57,8 @@ func TestGenerateDockerfile(t *testing.T) {
 }
 
 func TestBaseImageNameWithVersionModifier(t *testing.T) {
-	actual := BaseImageName("11.8", "3.8", "2.0.1+cu118")
-	require.Equal(t, "r8.im/cog-base:cuda11.8-python3.8-torch2.0.1", actual)
+	actual := BaseImageName("11.8", "3.9", "2.0.1+cu118")
+	require.Equal(t, "r8.im/cog-base:cuda11.8-python3.9-torch2.0.1", actual)
 }
 
 func TestBaseImageConfigurationExists(t *testing.T) {
@@ -86,7 +86,7 @@ func TestBaseImageConfigurationExistsNoTorch(t *testing.T) {
 
 func TestBaseImageConfigurationExistsNoCUDA(t *testing.T) {
 	cudaVersion := ""
-	pythonVersion := "3.8"
+	pythonVersion := "3.9"
 	torchVersion := "2.1"
 	client := registrytest.NewMockRegistryClient()
 	client.AddMockImage(BaseImageName(cudaVersion, pythonVersion, torchVersion))

pkg/dockerfile/monobase_matrix.go

@@ -56,9 +56,9 @@ func (m MonobaseMatrix) DefaultCudnnVersion() string {
 }
 
 func (m MonobaseMatrix) IsSupported(python string, torch string, cuda string) bool {
+	// Python 3.8 support was removed (EOL October 2024)
+	// Config validation will reject 3.8 before we get here, but keep check for safety
 	if python == "3.8" {
-		// coglet does not support Python 3.8, so we cannot use it for fast-push
-		// even though it's in the matrix for older models
 		return false
 	}
 	if torch == "" {

pyproject.toml

@@ -11,14 +11,13 @@ license.file = "LICENSE"
 urls."Source" = "https://github.com/replicate/cog"
 
 classifiers = [
-  "Programming Language :: Python :: 3.8",
   "Programming Language :: Python :: 3.9",
   "Programming Language :: Python :: 3.10",
   "Programming Language :: Python :: 3.11",
   "Programming Language :: Python :: 3.12",
   "Programming Language :: Python :: 3.13",
 ]
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 
 dependencies = [
   # intentionally loose. perhaps these should be vendored to not collide with user code?

python/cog/server/worker.py

@@ -640,8 +640,9 @@ def _predict(
         predict: Callable[..., Any],
         redirector: StreamRedirector,
     ) -> None:
-        with evolve_scope(context=context), self._handle_predict_error(
-            redirector, tag=tag
+        with (
+            evolve_scope(context=context),
+            self._handle_predict_error(redirector, tag=tag),
         ):
             result = predict(**payload)
 
@@ -695,8 +696,9 @@ async def _apredict(
         predict: Callable[..., Any],
         redirector: SimpleStreamRedirector,
     ) -> None:
-        with evolve_scope(context=context, tag=tag), self._handle_predict_error(
-            redirector, tag=tag
+        with (
+            evolve_scope(context=context, tag=tag),
+            self._handle_predict_error(redirector, tag=tag),
         ):
             future_result = predict(**payload)
 

test-integration/test_integration/fixtures/file-input-project/cog.yaml

@@ -1,3 +1,3 @@
 build:
-  python_version: "3.8"
+  python_version: "3.9"
 predict: "predict.py:Predictor"

test-integration/test_integration/fixtures/int-none-output-project/cog.yaml

@@ -1,3 +1,3 @@
 build:
-  python_version: "3.8"
+  python_version: "3.9"
 predict: "predict.py:Predictor"