fix: rescript-legacy broken for ppx's #8103
Merged
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves PPX errors with "Ill-formed list of warnings" after removal of -bs-v flag. The mtime from being appended to the -bs-v flag, after the change in rescript-lang#7627 it was being appended to the warnings flag instead, causing the compiler error Fixes rescript-lang#8090 Signed-off-by: Rob <illusionalsagacity@users.noreply.github.com>
illusionalsagacity
force-pushed
the
fix-8090-ppx
branch
from
b82e792 to
9061a4a
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Member
|
Just removing this is certainly the easiest solution if we don't want to bring BTW, rewatch currently doesn't currently check if a ppx was updated either. Maybe there could also be a hash over any ppx binaries like the Any thoughts @nojaf? |
Member
|
@cknitt are you talking about third-party ppx binaries here? |
Member
|
Yes, I meant third-party ppx. |
cknitt
approved these changes
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves PPX errors on v12 for rescript-legacy with "Ill-formed list of warnings" after removal of -bs-v flag. The mtime was previous appended to the -bs-v flag, after the change in #7627 it was being appended to the warnings flag instead, causing the compiler error
Fixes #8090