Skip to content

Add catch rate option#70

Merged
resetes12 merged 8 commits intoresetes12:masterfrom
InsertCreativeName5:AddCatchRateOption
Nov 30, 2025
Merged

Add catch rate option#70
resetes12 merged 8 commits intoresetes12:masterfrom
InsertCreativeName5:AddCatchRateOption

Conversation

@InsertCreativeName5
Copy link
Contributor

Description

Add logic for custom catch rate modifier. Scales 0.5-3x, without making some things like Ratata automatic or others like Legendaries impossible. Fits in well with player simplicity, while allowing vanilla experience

Discord contact info

insertcreativenamehere

@resetes12
Copy link
Owner

resetes12 commented Nov 30, 2025

Thanks! A pretty easy addition. However, there are a few things to do before I pull these changes:

  • First of all, new saveblock options CAN'T be added in between other existing options, as they mess up savegames (the game reads bits and bytes in the same place, regardless of the name of the option). They must be added at the end, below u8 tx_Mode_TypeEffectiveness:1;
  • Secondly, for existing savegames, the option will default to zero, which means that old players will have that option set to x0,5 catch rate. 1 must be x0,5 catch rate, while 0 has to be the default catch rate, even if by these numbers it doesn't make much sense.
  • Thirdly, not that important, but still. The Catch Rate option needs to be in the difficulty category. It's a minor thing, but catch rate is not a "feature". You can add it below "Hard mode exp. gain". Beware that there's currently a max of 15-16 options in each menu, but I think this one fits.

If you manage to do these changes, I would gladly add them, and even wait for them to release 3.3!

@InsertCreativeName5 InsertCreativeName5 marked this pull request as draft November 30, 2025 16:27
@InsertCreativeName5
Copy link
Contributor Author

Thanks! A pretty easy addition. However, there are a few things to do before I pull these changes:

* First of all, new saveblock options **CAN'T** be added in between other existing options, as they mess up savegames (the game reads bits and bytes in the same place, regardless of the name of the option). They must be added at the end, below `u8 tx_Mode_TypeEffectiveness:1;`

* Secondly, for existing savegames, the option will default to zero, which means that old players will have that option set to x0,5 catch rate. 1 **must** be x0,5 catch rate, while 0 has to be the default catch rate, even if by these numbers it doesn't make much sense.

* Thirdly, not that important, but still. The Catch Rate option needs to be in the difficulty category. It's a minor thing, but catch rate is not a "feature". You can add it below "Hard mode exp. gain". Beware that there's currently a max of 15-16 options in each menu, but I think this one fits.

If you manage to do these changes, I would gladly add them, and even wait for them to release 3.3!

Changes made, pipeline is failing build for some reason (maybe unrelated to change?), switched to draft until figured out

@InsertCreativeName5
Copy link
Contributor Author

@resetes12 are you able to check the workflow? I think the compilation requires libpng package in the apt-get, or something like that. Compilation works fine on my PC, even when I run git clean -fdx in the repo first.

@resetes12 resetes12 marked this pull request as ready for review November 30, 2025 17:18
@resetes12 resetes12 merged commit fa78330 into resetes12:master Nov 30, 2025
1 check failed
@resetes12
Copy link
Owner

resetes12 commented Nov 30, 2025

All good, don't worry. I have zero clue about how the workflow stuff works, to be honest.

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants