Skip to content

Conversation

@rburghol
Copy link
Contributor

@rburghol rburghol commented Jun 18, 2025

@PaulDudaRESPEC
This PR fixes a bug in the special actions code whereby the ELSE statement is not caught and parsed, resulting in an error. Notes:

  • It does not yet add correct IF-THEN-ELSE support (that is coming very very soon).
  • Ir does allow a UCI to have structures containing an ELSE and not fail.
  • This is also a test to see how the automated testing goes for this (last PR was 3 months ago and testing results no longer are available).
    • It appears that recent updates to h5 library code cause hsp2 import_uci ... calls to fail due to a redundant call to open the h5 file.
    • This error throws in python 3.9, but does not appear in python 3.12 as of this PR. This is mentioned in a comment to HSPsquared model created from ./tests/land_spec/hwmA51800.uci fails with KeyError #180 (they are maybe related as one throws a KeyError and the other a ValueError). @timcera
    • Note: Automated testing of python 3.9 completes both hsp2 import_uci ... and hsp2 run ..., so this may be a problem with my local install/lib setup? I will report back here.

Burgholzer and others added 7 commits June 16, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants