Rename "uci" to "parameters" or "model" as appropriate. #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like a significant step towards getting Special Actions implemented!
Adding a bit more documentation and additional examples for the interactive HoloViz plotting libraries that we use.
Initial SPECL.py PR
Adjust Columns to Parse HYDRO-INIT block
* Some pandas offset codes changed in pandas 2.2. If <2.2 offset
codes are with >2.2 throws deprecation warnings and if >2.2 codes
used with <2.2 throws value errors. Using the new
"pandas_offset_by_version" function will used the >2.2 codes and
change to the older codes if run with pandas <2.2.
* Fixed to_numeric(..., errors="ignore", ...) deprecation warnings.
* Fixed resample(..., kind="timestamp", ...) deprecation warnings.
* Removed unused FILES block entry for WDM2 and fixed comments
("***" has to be in columns less than 80) in
tests/ZRW_WestIndian/HSPF.uci and removed the unused
tests/ZRW_WestIndian/HSPF.WDM.
* Added missing WDM file in tests/ipwater.
@PaulDudaRESPEC, @timcera, @rburghol & @austinorr, the example 1 notebook now works by installing from the conda environment file. Most importantly this example notebook provides an example of how the IO manager should be used, as described in respec#182 (comment)
@PaulDudaRESPEC, this reverts things back to how @timcera set them up, so that we can merge PR respec#184 into `develop` as soon as possible, so that others can run the example with IOManager.
Let's leave pandas version unconstrained in the recommended environment. I think we should frankly do the same for Python, changing these two lines to: ```yml name: hsp2 - python >=3.10 ```
Conda tweaks and Fix Example Notebook 1
Added "pandas_offset_by_version" to address deprecated offset codes.
To follow conventions (i.e. putting Python version at top; put env managment at the bottom). Also changed default env name to `hsp2` and unconstrained Python to >=3.10
…docstrings @timcera, this commit fixes the version attribute import error when in conda develop mode, while also preserving the versioning for packaging. It does so by moving the code from `_version.py` into the main init file. Thanks @ptomasula for helping me work through this "cake-and-eat-it-too" approach!
Fixed versions in develop mode; Module docstrings; More Env Improvements
…ecl and simple main loop prototype
Develop step
…s were flipped, should be exits first, then sand-silt-clay; seen in UCI with explicit masslinks RQUAL.py -- fix bug, only save timeseries from active RQUAL sections om_special_action.py -- integer action code not interpreted correctly (1 for =) utilities.py -- update to pandas_offset_by_version ParseTable.csv -- add more GENER tables readUCI.py -- add more GENER tables, fix for implied exponential format monthdata tables
…D SEDMNT section, implemented for DETS which is a common use of special actions
… from the RCHRES RQUAL sections
PQUAL.py, PWATER.py -- catch possible divide by zero error utilities.py -- more robust checking in ts DIV
* In some places "uci" would describe "parameters" and in other places would describe "model". Changed as appropriate. * Applied "ruff check --fix ." safe fixes. * Applied "ruff format .".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.