New quickstart #214
Merged
New quickstart #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
templates/java-maven-spring-boot/src/main/java/com/example/restatestarter/Utils.java
Outdated
Show resolved
Hide resolved
templates/java-maven-spring-boot/src/main/java/com/example/restatestarter/Utils.java
Outdated
Show resolved
Hide resolved
templates/java-maven-spring-boot/src/main/java/com/example/restatestarter/Greeter.java
Show resolved
Hide resolved
templates/rust-shuttle/src/utils.rs
Outdated
| pub fn send_notification(greeting_id: &str, name: &str) { | ||
| if random::<f32>() < 0.5 { | ||
| println!("👻 Failed to send notification: {} - {}", greeting_id, name); | ||
| panic!("Failed to send notification: {} - {}", greeting_id, name); |
Contributor
There was a problem hiding this comment.
not a good idea, convert this to error. I'm not even sure we catch panics actually.
Contributor
There was a problem hiding this comment.
one thing you can do to make this code better overall is the following:
Change the signature of this function to
pub async fn send_notification(greeting_id: &str, name: &str) -> anyhow::Result<()>
And then the context run should be as easy as
ctx.run(|| send_notification(&greeting_id, &name)).await?
templates/rust/src/utils.rs
Outdated
| @@ -0,0 +1,17 @@ | |||
| use rand::random; | |||
|
|
|||
| pub fn send_notification(greeting_id: &str, name: &str) { | |||
Contributor
There was a problem hiding this comment.
Same comments above
# Conflicts: # templates/java-gradle/src/main/java/my/example/Greeter.java # templates/java-maven/src/main/java/my/example/Greeter.java
Contributor
slinkydeveloper
left a comment
slinkydeveloper
left a comment
There was a problem hiding this comment.
one minor thing and lgtm
Comment on lines
+7
to
+12
| class GreetingRequest(BaseModel): | ||
| name: str | ||
|
|
||
|
|
||
| class Greeting(BaseModel): | ||
| message: str |
Contributor
There was a problem hiding this comment.
I would honestly have them in example.py, makes the whole thing way more readable, and this is super small...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to show Durable Execution in the quickstart. This allows us to make the quickstart touch upon the main features of Restate.