[WIP] Chunk compression improvements.#126
Draft
gibsonpil wants to merge 4 commits intoretromcorg:masterfrom
Draft
[WIP] Chunk compression improvements.#126gibsonpil wants to merge 4 commits intoretromcorg:masterfrom
gibsonpil wants to merge 4 commits intoretromcorg:masterfrom
Conversation
Member
|
@gibsonpil Any update on this? |
Author
|
This seems like one of those projects that I forgot about after getting busy with university. Nonetheless, this actually seems like a pretty cool pull request, so I will finish it as soon as I have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is intended to backport some of the improvement made to chunk compression in newer updates and also introduce some new ones.
Todo List:
lz4support (backport from 24w04a).xzsupport.XZYtoYZX(backport from Anvil).I've also generated (unscientific) benchmarks by regenerating a world with the same seed, immediately exiting the server, and marking down the file size generated by each compression type. I will write a proper, scientific benchmark later.
Unscientific Benchmarks:
EDIT: Dropped idea of adding ZSTD support. It doesn't have a Java native version compatible with Java 1.8, and bundling a native version to use with the JNI would just overcomplicate things.
EDIT 2: Ran some benchmarks and decided XZ would be an appropriate substitute for ZSTD.