Draft
Conversation
Author
|
I would recommend viewing this in split mode rather than unified |
xXGunner989Xx
commented
Mar 10, 2025
Contributor
|
would it be possible to add a config key with which you can specify what type of line wrapping (Vanilla, CB, Poseidon) you would like to use? (#39) |
Contributor
|
A function at the bottom of the file called |
xXGunner989Xx
commented
Mar 12, 2025
RitzKid76
reviewed
May 18, 2025
RitzKid76
reviewed
May 18, 2025
RitzKid76
requested changes
May 28, 2025
Contributor
RitzKid76
left a comment
RitzKid76
left a comment
There was a problem hiding this comment.
Each of the "words" sent started with "01234567889". There appears to be some message cutoff issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this one hurt ngl
basically rewrote the whole text wrap from scratch to fix the weird spacing goofyness from the original implementation. for quality/readability improvements, made it so that the wrapping is at word level instead of character level. i tried to write comments on most of the logic so others can understand the flow here. also using a temp char that is UTF8 because I was getting paranoid about \n.