feat: Api to display inventory to remote player#176
feat: Api to display inventory to remote player#176OldManYells wants to merge 1 commit intoretromcorg:masterfrom
Conversation
646cf14 to
685cfd6
Compare
685cfd6 to
830cc0c
Compare
|
While I think this is a cool feature I don't know if features that are traditionally added by most major server eco/moderation plugins should be getting added to the server jar when it can be done via plugins. Additionally if this does get added, the command should fall under a |
This PR atm only exposes through Bukkit what otherwise is only called by server internal code, the actual feature/command would be added in a plugin or as you mentioned in /poseidon. Not sure if you mean something else or you are referring to a previous commit that also added the command. |
Yeah I figured the PR was a draft of some kind going off of it's previous title talking about adding it as a command. |
|
@Garsooon how would you like to go about on this? |
|
Up to @RhysB, however when we were talking about it briefly in both forms (api/command) it probably wouldn't be needed since B1.7.3 plugins already can and have accessed inventories using NMS among other things. |
|
Yes. The point is exposing it clearly to the API. As an exempla the only current plugin that allows an OP to check a player inventory is a "read only" functionality(afaik and what is used in rmc). With this clearly exposed is easy to understand that not only is possible but it's easy to create a plugin that allows operators to directly edit a players inventory. |

This PR exposes a cleaner interface to allow displaying inventories remotely
Please review and let me know if this functionality should be placed some other place.