feat: Add UUID integration for bans, whitelist and ops#178
Open
OldManYells wants to merge 1 commit intoretromcorg:masterfrom
Open
feat: Add UUID integration for bans, whitelist and ops#178OldManYells wants to merge 1 commit intoretromcorg:masterfrom
OldManYells wants to merge 1 commit intoretromcorg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates PoseidonUUIDs with standard validations for ban/op/whitelist. Currently commands are not set to support direct use of UUID.
Motivation & Context
In order to improve security and among other things reduce ban avoidance by name changing.
Type of Change
Please tick all that apply:
Testing Performed
Tested ban/pardon, op/deop, whitelisting ops in general to look for proper storing and validation as well as no crash or error.
Compatibility Considerations
The code is designed to keep both models working and reconcile from standard text/name based approach to the new that includes UUID.
Additional Notes
Some function wrapping and comments were added to improve readability.