Added values for inset percentage content offsets #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehlersd
changed the title
sochalewski
approved these changes
Sep 10, 2019
reydanro
requested changes
Sep 13, 2019
| @property (nonatomic) CGFloat insetLeftPercentage; | ||
| @property (nonatomic) CGFloat insetRightPercentage; | ||
| @property (nonatomic) CGFloat insetTopPercentage; | ||
| @property (nonatomic) CGFloat insetBottomPercentage; |
Owner
There was a problem hiding this comment.
These are called inset but they seem to behave like outset? A positive value will push the image outwards.
Also, I'd prefer UIEdgeInsets as that's a standardized way to refer to paddings.
The way I would see this is the UIEdgeInsets would restrict the boundaries in which the alignment will happen.
ashoag-design
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you want to merge this option into your repo or not. It was needed for our purposes to try to improve content centering, so I'd love to get it added to the main distribution, but if not, I understand.
Thanks for the code!