Skip to content

Conversation

@jenniferholm
Copy link

Description:

This pull request is adding in a user specified switch to turn on or off the day length scaling factor, that is applied to the photosynthetic parameters Vcmax25 and jmax25. This is to be able to allow backwards compatibility with previous versions of the calibration branch.
The function daylength is a scaling factor that is based on the formulation in Bauerle et al. (2012), which quantifies the relationship between day length and Jmax.

Collaborators:

Greg Lemieux

Expectation of Answer Changes:

The default is to have the day length factor turned on (equal to 1 in the parameter file), and should have the same results as the most recent calibration branch found here (https://github.com/rgknox/fates/tree/unsupported_sp_calibration_api31)

If turned off, this will change values related to photosynthesis, GPP, and downstream results.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

E3SM test hash-tag: a7f4ecb9dd

E3SM baseline hash-tag: a7f4ecb9dd

FATES baseline hash-tag: f8bf84c

Test Output:

/pscratch/sd/j/jaholm/e3sm_scratch/pm-cpu/fates_prr_test.pm-cpu.Ea7f4ecb9dd-F4e103117.2023-12-30/run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant