Skip to content

Conversation

@zzambers
Copy link
Contributor

@zzambers zzambers commented Dec 9, 2025

Update scala version to 2.13.18 to support JDK26.

@zzambers
Copy link
Contributor Author

zzambers commented Dec 9, 2025

Hmm, looking at code this does not seem to do anything apart from changing dir name for cloned repo. Also repo is not upstream one but https://github.com/judovana/scala.git. Not sure why.

Edit: Oh, it uses custom branch with some workarounds. We will probably need to rabase that...

Edit2: Nevermind, I see that changes made it to upstream, I'll update the PR to use upstream then.

@zzambers zzambers marked this pull request as draft December 9, 2025 19:13
@zzambers zzambers marked this pull request as ready for review December 9, 2025 19:32
Copy link

@andrlos andrlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job

@zzambers
Copy link
Contributor Author

zzambers commented Dec 9, 2025

btw. Someone else will need to merge this. I don't have permission in this repo.

scalav=2.13.18
wget https://github.com/sbt/sbt/releases/download/v$sbtv/sbt-$sbtv.tgz
tar -xf sbt-$sbtv.tgz
git clone https://github.com/judovana/scala.git scala-$scalav
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for record, the chnages in that fork were all emrged to usptream.

wget https://github.com/sbt/sbt/releases/download/v$sbtv/sbt-$sbtv.tgz
tar -xf sbt-$sbtv.tgz
git clone https://github.com/judovana/scala.git scala-$scalav
wget -O scala-$scalav.tar.gz https://github.com/scala/scala/archive/refs/tags/v$scalav.tar.gz
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My trust to wget is already zero... Would much rather stay on clone

@judovana judovana merged commit e34ae15 into rh-openjdk:main Dec 19, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants