-
Notifications
You must be signed in to change notification settings - Fork 1
Update scala to version 2.13.18 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hmm, looking at code this does not seem to do anything apart from changing dir name for cloned repo. Also repo is not upstream one but Edit: Oh, it uses custom branch with some workarounds. We will probably need to rabase that... Edit2: Nevermind, I see that changes made it to upstream, I'll update the PR to use upstream then. |
31a8bd5 to
92eb269
Compare
92eb269 to
c57d02f
Compare
andrlos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job
|
btw. Someone else will need to merge this. I don't have permission in this repo. |
| scalav=2.13.18 | ||
| wget https://github.com/sbt/sbt/releases/download/v$sbtv/sbt-$sbtv.tgz | ||
| tar -xf sbt-$sbtv.tgz | ||
| git clone https://github.com/judovana/scala.git scala-$scalav |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for record, the chnages in that fork were all emrged to usptream.
| wget https://github.com/sbt/sbt/releases/download/v$sbtv/sbt-$sbtv.tgz | ||
| tar -xf sbt-$sbtv.tgz | ||
| git clone https://github.com/judovana/scala.git scala-$scalav | ||
| wget -O scala-$scalav.tar.gz https://github.com/scala/scala/archive/refs/tags/v$scalav.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My trust to wget is already zero... Would much rather stay on clone
Update scala version to 2.13.18 to support JDK26.