Skip to content

Conversation

@elai-shalev
Copy link
Collaborator

@elai-shalev elai-shalev commented Jan 5, 2025

Closes https://issues.redhat.com/browse/FLPATH-1920

These changes were tested incrementally.

(1) Workflows with '.' in their name could be build but did not show on RHDH for error 1 below
(2) Workflows with Capital letters and numbers at the start could not be build with argocd for error 2 below.
(3) Hyphens are allowed in argocd and k8s, but are prohibited in workflows created because of using java.

Eventually the field of names for "workflows created by software templates, including custom java code, deployed by argocd and run on RHDH" are of names that have a lowercase alphabetical start, no hyphens, no periods, and all other chars being lowercase alphanumerical.

Errors:
(1)

     "testing.bug9" is invalid: metadata.name: Invalid value: "testing.bug9": a DNS-1035
     label must consist of lower case alphanumeric characters or ''-'', start with
     an alphabetic character, and end with an alphanumeric character (e.g. ''my-name'',  or
     ''abc-123'', regex used for validation is ''[a-z]([-a-z0-9]*[a-z0-9])?''))'

(2)
Error from server (Invalid): error when creating "F05EB00E.D9D7.46B1.BC27.136EB02E22E1-argocd-app-bootstrap.yaml": Application.argoproj.io "F05EB00E.D9D7.46B1.BC27.136EB02E22E1" is invalid: metadata.name: Invalid value: "F05EB00E.D9D7.46B1.BC27.136EB02E22E1": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

@gabriel-farache gabriel-farache merged commit 7d67f56 into rhdhorchestrator:main Jan 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants