Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://issues.redhat.com/browse/FLPATH-1920
These changes were tested incrementally.
(1) Workflows with '.' in their name could be build but did not show on RHDH for error 1 below
(2) Workflows with Capital letters and numbers at the start could not be build with argocd for error 2 below.
(3) Hyphens are allowed in argocd and k8s, but are prohibited in workflows created because of using java.
Eventually the field of names for "workflows created by software templates, including custom java code, deployed by argocd and run on RHDH" are of names that have a lowercase alphabetical start, no hyphens, no periods, and all other chars being lowercase alphanumerical.
Errors:
(1)
(2)
Error from server (Invalid): error when creating "F05EB00E.D9D7.46B1.BC27.136EB02E22E1-argocd-app-bootstrap.yaml": Application.argoproj.io "F05EB00E.D9D7.46B1.BC27.136EB02E22E1" is invalid: metadata.name: Invalid value: "F05EB00E.D9D7.46B1.BC27.136EB02E22E1": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')