remove assessment workflow

[ydayagi]

FLPATH-2324
https://issues.redhat.com/browse/FLPATH-2324

[elai-shalev]

Some more comments:

1. Should we remove the deprecation notices from all docs and relevant files now that the deprecation has been performed?

2. Were all templates tested after the changes? The templates can be unpredictable with changes, especially when changing the workflow in the skeleton projects

[elai-shalev]

About L18-30
So we're keeping the "SampleAssessment" java class, but only updating the workflowId and not "mimicing the assessment"? Did you consider renaming this action + Java class to have no "assessment" wording remaining?

[ydayagi]

i prefer not to rename or change the logic. i think this will be revised later on by motu and piotr and you and others. not sure which direction this will go. so better keep it simple.

[ydayagi]

Some more comments:

1. Should we remove the deprecation notices from all docs and relevant files now that the deprecation has been performed?
2. Were all templates tested after the changes? The templates can be unpredictable with changes, especially when changing the workflow in the skeleton projects

@elai-shalev about the deprecation notice we should ask @pkliczewski and @masayag and perhaps you have an opinion. what do u suggest?
For testing it officially I would be glad to receive instructions on how to test it. I saw a CI e2e test so I figured we are covered

[ydayagi]

@elai-shalev @masayag

I removed the deprecation notice

[elai-shalev]

Hey @ydayagi
The CI passed but looking into the log itself I believe if might have not actually validates that the templates are correct.
looking at ADVANCED_TASK_ID is null in the log tells me that the template wasn't properly launched. Probably a falso positive of the CI.

To test the software templates, you need:

1. Replace the catalog URLs in the RHDH catalog config in the Go-operator here to use the URLs to the templates in this PR. You can also just install the operator regularly, scale down rhdh, replate the catalog items in the configmap and redeploy rhdh.
2. Your RHDH should be configured with all the necessary github/gitlab requirement. QE has a job to configure all of this automatically, you could ask them for a cluster/ use the testing cluster
3. Once you have the correct new software templates in RHDH, run them through the catalog and make sure they work

[elai-shalev]

Also about the deprecation notice, I think we should remove all notices in a seperate PR once all code deprecation PRs are merged

[ydayagi]

@elai-shalev @masayag during planning we said the @elai-shalev will test software templates. so I think we can go ahead and merge

[elai-shalev]

LGTM, withstanding the templates were not tested thoroughly. If needed a patch/fix will be added.