Fix/advanced template #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
There was a problem hiding this comment.
those changes are unrelated to the fix, right?
I'm fine with doing those quick refactors, if you can, next time, put them in a separate commit so I know it's unrelated :)
Collaborator
Author
There was a problem hiding this comment.
the removal of workflowId is related to (1), the gitlab templates related to the bug
I would have split them but its just one line so I figured we'd manage
Collaborator
Author
There was a problem hiding this comment.
I'll make the comment more informative
Collaborator
There was a problem hiding this comment.
It's fine to group the small fixes in PR, the commits should reflects each fix individually :)
gabriel-farache
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.