Conversation
arijoon
left a comment
arijoon
left a comment
There was a problem hiding this comment.
Looks good, I'm guessing we just copy/paste the swagger.json over the v12 file anytime we have an API update and all should work as expected?
| "dependencies": { | ||
| "@babel/polyfill": "^7.8.3", | ||
| "highlight-words-core": "^1.2.2", | ||
| "lodash.mapvalues": "^4.6.0", |
There was a problem hiding this comment.
might as well include the entire lodash
There was a problem hiding this comment.
I was doing this before noticing that we've done this type of fine grained dep injection so I figured out there might be a reason although I am not sure. Do you think the weight different will be negligible if we import everything ?
There was a problem hiding this comment.
indeed, especially in our usecase a few more KBs of lodash won't really have a major effect
src/spec/makePythonCode.js
Outdated
| getHeadersWithExtras(parameters.filter(parameter => parameter.in === 'header')) | ||
| ).map(([key, value]) => ` "${key}": "${value}"`) | ||
| .join(',\n') + '\n' + | ||
| // ' "Accept": "application/json",\n' + |
There was a problem hiding this comment.
can this be removed or is it needed in the future?
There was a problem hiding this comment.
Looks good, I'm guessing we just copy/paste the
swagger.jsonover thev12file anytime we have an API update and all should work as expected?
Correct. I'll add something in Confluence to explain the process, but it should be globally unchanged. The goal is to make doc updates as easy as possible so it can be updated more or less at the same time
There was a problem hiding this comment.
It would be a really nice step if we let this automatically fetch the swagger.json file from our API and only provide the overlay, this will make sure it's always in sync
There was a problem hiding this comment.
Done in latest commits ;)
Neozaru
force-pushed
the
fix/VEN-54-fixDocumentationValues
branch
from
8eb1894 to
cd3f36d
Compare
…crash when reading non tagged entries
4 participants
Related to https://darcs.atlassian.net/browse/VEN-54?atlOrigin=eyJpIjoiNGIzZDg1NDI3MWRkNDEyNGIxNjNjNzkzZDlmODA3ZTgiLCJwIjoiaiJ9