Skip to content

Conversation

@dzebisati
Copy link

@dzebisati dzebisati commented Dec 31, 2024

Continue of the disscution in #34

When user defines own "page" logic via data-should-snap attribute, in some cases prev method stop working as expected.

Demo with examples on sandbox

@KasperAndersson
Copy link

@richardscarrott, any plans to close this, or did you stop maintaining the lib?

@richardscarrott
Copy link
Owner

richardscarrott commented Sep 17, 2025

@KasperAndersson tbh I'm a little unsure I want to maintain support for data-should-snap as it's adding more complexity than I anticipated and I'm not completely sold on the feature — it was originally added to help me experiment with infinite carousels a while back and is undocumented.

Are you experiencing the same issue and does this PR solve it for you?

@KasperAndersson
Copy link

Hi @richardscarrott ,

We'ven't actually used the option, as it hasn't been required by our design. We're currently undergoing some re-implementations that require us to use the data-should-snap attribute, and we're now experiencing the same issue that this PR solves. Tried using this branch, and it fixes the problem with prev button casually being unresponsive.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants