Make the 'message' sub-field of an 'Item' optional (it does not occur…#32
Open
peddie wants to merge 1 commit intorickeyski:masterfrom
Open
Make the 'message' sub-field of an 'Item' optional (it does not occur…#32peddie wants to merge 1 commit intorickeyski:masterfrom
peddie wants to merge 1 commit intorickeyski:masterfrom
Conversation
… in the 'item' objects in reaction events)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the 'message' sub-field of an 'Item' optional (it does not occur in the 'item' objects in reaction events).
This is more fallout from #21. The code here doesn't match the API docs for the RTM API or any message items I've seen so far, but I haven't restructured the
MessageItemfield, because a) we know the API docs are incorrect and b) I don't know where the code came from, and maybe it's still valid elsewhere.