Tracklib2 #4
Open
Tracklib2 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's covered by the crc for the whole data section
This code is capable of writing more than 64 fields, and also the byte order is reversed - making it more clear, IMO.
jmoniatte
reviewed
Jun 9, 2022
jmoniatte
left a comment
jmoniatte
left a comment
There was a problem hiding this comment.
Besides "what's up with all those .rs files?", I am unfortunately not able to provide much feedback. The ruby code and API look very good to me though, thanks Dan!
I wanted to request a few examples in README.md, but realized that the spec files can be used for that.
Update name to Tracklib2 and build on install
kingcu
approved these changes
Nov 21, 2022
This fixes a couple bugs that could have been caused by failed writes. Previously, if a write failed (however unlikely that is) then the `prev` field in the encoder would still have been changed, and so future writes would have been corrupted. The same is true for updating the presence column - now it only happens after the write succeeds.
Wrapping add/sub is the default in release mode, so this change has no effect for production builds. But in debug mode, checked math is the default, so this change allows the roundtrip integration tests to run then too.
This commit doesn't change the F64 Encoder, even though it uses write_i64. Those changes will be in the next commit.
The F64 Encoder can't accurately store the entire range of 64-bit floating point numbers, since it's basically a fixed point system. This change will cause it to return an error when there isn't enough space to store the value it's been asked to encode.
Tracklib2 pr3 api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.