-
Notifications
You must be signed in to change notification settings - Fork 130
Explorer Lending Protocol Object Page #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ckeshava
wants to merge
38
commits into
ripple:staging
Choose a base branch
from
ckeshava:lpObjectPage-draft1
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility of multiple loan brokers
… it paid off; TODO: Verify the behavior of Impaired and Defaulted loans
…million, k for thousands); formatted Total-Debt and Maximum-Debt values in the LoanBroker section
…ly used util methods
…from XRPLMeta service
Contributor
Author
|
Note: Appropos the Github CI linter errors, the changes requested by It is not useful to work with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR implements an Explorer Lending-Protocol Object Page. It provides a readable version of Single-Asset-Vaults to the viewers.
If you would like to interact with the new Lending Protocol Object Page, please run a local instance of the Explorer with this PR's changes and navigate to http://localhost:3000/lend.devnet.rippletest.net:51233/vault/3E7B7873E696C8055302F2EA3669E6C447FB3606B92E6451AF1CD2BACFFB1F0E on your browser.
Refer to this screen recording video to see a visual preview of the new Explorer Vault page: https://github.com/user-attachments/assets/e7707a9f-6bde-40cf-8239-b700cfb02a24
Type of Change
Codebase Modernization
Before / After
Test Plan
Appropriate tests have been added to the new feature.