Conversation
silver-rise
requested review from
datnguyencse,
duyquang6,
hai-rise,
kien-rise and
phuocthanhdo
as code owners
hai-rise
requested changes
Oct 22, 2025
hai-rise
requested changes
Oct 23, 2025
silver-rise
force-pushed
the
loc/dedup-code
branch
from
e48a4c2 to
3c62233
Compare
hai-rise
requested changes
Oct 23, 2025
silver-rise
force-pushed
the
loc/dedup-code
branch
from
02dbade to
e70d547
Compare
silver-rise
force-pushed
the
loc/dedup-code
branch
from
e70d547 to
392df5c
Compare
hai-rise
approved these changes
Oct 23, 2025
Contributor
hai-rise
left a comment
hai-rise
left a comment
There was a problem hiding this comment.
We'll need to rework the chain abstraction for sure, but for now, this actually turned out better than I'd imagined. Nice!
This was referenced Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.