[WIP] feat: refactor token pages #246
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
dcea078
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d483924f.frontend-3mt.pages.dev |
| Branch Preview URL: | https://refactor-refactormarketsandt.frontend-3mt.pages.dev |
pyk
requested changes
Jul 3, 2022
Contributor
pyk
left a comment
pyk
left a comment
There was a problem hiding this comment.
error in build:
14:00:01.457 | https://nextjs.org/telemetry
-- | --
14:00:01.457 |
14:00:01.588 | info - Checking validity of types...
14:00:10.414 | Failed to compile.
14:00:10.414 |
14:00:10.414 | ./pages/[chains]/markets/[token].tsx:13:32
14:00:10.414 | Type error: Cannot find module '../../../modules/tokenPage/tokenContainer' or its corresponding type declarations.
14:00:10.415 |
14:00:10.415 | �[0m �[90m 11 \| �[39m�[36mimport�[39m { useRouter } from �[32m"next/router"�[39m�[33m;�[39m�[0m
14:00:10.415 | �[0m �[90m 12 \| �[39m�[36mimport�[39m �[33mReact�[39m�[33m,�[39m { useEffect�[33m,�[39m useMemo } from �[32m"react"�[39m�[33m;�[39m�[0m
14:00:10.415 | �[0m�[31m�[1m>�[22m�[39m�[90m 13 \| �[39m�[36mimport�[39m { �[33mTokenContainer�[39m } from �[32m"../../../modules/tokenPage/tokenContainer"�[39m�[33m;�[39m�[0m
14:00:10.415 | �[0m �[90m \| �[39m �[31m�[1m^�[22m�[39m�[0m
14:00:10.415 | �[0m �[90m 14 \| �[39m�[36mimport�[39m �[33mNavigation�[39m from �[32m"../../../components/v1/Navigation"�[39m�[33m;�[39m�[0m
14:00:10.415 | �[0m �[90m 15 \| �[39m�[36mimport�[39m { useTokenStore } from �[32m"../../../modules/tokenPage/store/tokenStore"�[39m�[33m;�[39m�[0m
14:00:10.415 | �[0m �[90m 16 \| �[39m�[0m
14:00:10.449 | Failed: build command exited with code: 1
14:00:11.639 | Failed: an internal error occurred
pyk
reviewed
Jul 3, 2022
| export function useLeveragedTokenNAV(req: LeveragedTokenNAVRequest) { | ||
| const { data, error } = useSWR<ethers.BigNumber, Error>( | ||
| export function useLeveragedTokenNAV(req: LeveragedTokenNAVRequest, options?: SWRConfiguration) { | ||
| const { data, error, mutate } = useSWR<ethers.BigNumber, Error>( |
Contributor
Author
There was a problem hiding this comment.
because i want to re-fetch data when error appears
pyk
reviewed
Jul 3, 2022
| balanceResponse.mutate(); | ||
| }; | ||
|
|
||
| useEffect(() => { |
Contributor
There was a problem hiding this comment.
Why we have multiples useEffect() ?
Contributor
Author
There was a problem hiding this comment.
because it's specific usage.
this side effect will only run when dependencies changes value
because i think if you combine them , it may create unexpected re-render and side effect
asaadam
force-pushed
the
refactor/refactorMarketsAndTokenPages
branch
from
46f81e7 to
dcea078
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor token pages