chore(pgwire): add start of execution logs for all queries #24079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
If
PGWIRE_QUERY_LOGis enabled, we will also log at the start of query execution, not just when the query finishes execution. This allows us to review queries which encounterOOMorabortwhich can't be caught by the runtime. The result is that we will lose these queries that were executed.A note on overhead: Currently, if
PGWIRE_QUERY_LOG=infois set, we will already emit at least one log for the query on its completion. We add one more log line for start of execution. If the overhead is too high for the user, they can always switch off query logging.If the overhead is unacceptable, we could downgrade the log level to debug. But I prefer to keep it enabled, or else we have to wait for the event to occur.
Checklist
Documentation
Release note