refactor: consolidate ThrottleType enum to common.proto #24083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
- Move ThrottleType enum from meta.proto to common.proto to eliminate duplication - Remove nested ThrottleType enum from stream_plan.proto - Update all references to use risingwave_pb::common::ThrottleType - Add ThrottleType re-export in executor/mod.rs for consistency - Update cdc_backill_v2.rs to use crate::executor::ThrottleType Co-authored-by: kwannoel <47273164+kwannoel@users.noreply.github.com>
Update all ALTER statements to use risingwave_pb::common::PbThrottleType instead of risingwave_pb::meta::PbThrottleType Co-authored-by: kwannoel <47273164+kwannoel@users.noreply.github.com>
Make all references use risingwave_pb::common::PbThrottleType for consistency Co-authored-by: kwannoel <47273164+kwannoel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for sink backfill rate limit
refactor: consolidate ThrottleType enum to common.proto
Dec 10, 2025
github-actions
bot
added
ci/run-e2e-single-node-tests
ci/run-e2e-test-other-backends
type/refactor
kwannoel
added a commit
that referenced
this pull request
Dec 15, 2025
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kwannoel <47273164+kwannoel@users.noreply.github.com>
kwannoel
added a commit
that referenced
this pull request
Dec 18, 2025
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kwannoel <47273164+kwannoel@users.noreply.github.com>
kwannoel
added a commit
that referenced
this pull request
Dec 18, 2025
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kwannoel <47273164+kwannoel@users.noreply.github.com>
kwannoel
added a commit
that referenced
this pull request
Dec 19, 2025
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kwannoel <47273164+kwannoel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Addresses review comments from #24075 by consolidating duplicate
ThrottleTypeenum definitions.Proto consolidation
ThrottleTypeenum frommeta.prototocommon.proto(already imported by bothmeta.protoandstream_plan.proto)ThrottleTypefromstream_plan.proto::ThrottleMutationcommon.ThrottleType, eliminating duplication and drift riskRust code consistency
pub use risingwave_pb::common::ThrottleTypetoexecutor/mod.rscdc_backill_v2.rsto usecrate::executor::ThrottleTypepattern consistent with other executorsrisingwave_pb::meta::ThrottleType→risingwave_pb::common::ThrottleTypeacross frontend, meta, rpc_client, and ctl cratesEnum values unchanged; backward compatible.
Checklist
Documentation
Release note
None - internal refactoring only.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.